search

ManageIQ / azure-armrest

Ruby interface for Azure using the new REST API
Apache License 2.0
15 stars 36 forks source link

[FINE] Changes for the 0.8.7 release #343

Closed bronaghs closed 6 years ago

bronaghs commented 6 years ago

Updates the CHANGES file with the change included in 0.8.7

I noticed 0.8.6 is not included in this file, but I did not want to add an entry because I do not see the PR in the 0.8.x commit log @djberg96 - can you investigate?

djberg96 commented 6 years ago

Apparently I made the change locally, but never pushed it up. Not a huge deal. Just add this to the CHANGES file:

= 0.8.6 - 23-Oct-2017
* Backported the '$' model key fix from 0.9.1.
bronaghs commented 6 years ago

Actually @djberg96 (When you are not on PTO) - I didn't see the PR in the commit log for 0.8.x, do you know why?

djberg96 commented 6 years ago

Ugh, it didn't get pushed up (but it is in the gem). The rake release task blows up when it's not master, and I guess I never did it manually.

I'll have to do some git surgery since a change has since been comitted.

bronaghs commented 6 years ago

What is confusing is that the fix is in the 0.8.6 files eg https://github.com/ManageIQ/azure-armrest/blob/v0.8.6/spec/models/base_model_spec.rb#L217..#L223 but the commit isnt in the log...

miq-bot commented 6 years ago

This pull request is not mergeable. Please rebase and repush.

miq-bot commented 6 years ago

Checked commit https://github.com/bronaghs/azure-armrest/commit/f14405a3a72755b4a6f808ed7b8df1ead339d6e3 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 0 files checked, 0 offenses detected Everything looks fine. :trophy:

djberg96 commented 6 years ago

Just a quick followup. For backports I've just been doing cherry-picks and pushing them up. I made the changes locally for 0.8.6 but never pushed up the commits. The 0.8.6 gem DOES have the expected fixes, though. It was only the repo that got out of sync.

Anyway, the commits were added back in and pushed up, so a small bit of confusion as we reworked this PR.

djberg96 commented 6 years ago

LGTM 👍