Use caller_locations instead of caller

ManageIQ / azure-armrest

Ruby interface for Azure using the new REST API

Apache License 2.0

15 stars 36 forks source link

Use caller_locations instead of caller #344

Closed NickLaMuro closed 6 years ago

NickLaMuro commented 6 years ago

Ruby already has a mechanism in place for getting the callstack path locations and line numbers that doesn't require string splitting/parsing.

This also fixes a bug on Windows systems when trying to split callstacks with file paths in them, since most windows file paths include something like 'C:/path/to/file', which has an additional ':' that is not expected by the codebase.

Fixes some of https://github.com/ManageIQ/azure-armrest/issues/332

cc @djberg96

miq-bot commented 6 years ago

Checked commit https://github.com/NickLaMuro/azure-armrest/commit/7b44f154ceab31b5e3b5da4551b114ca26a22363 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 1 file checked, 0 offenses detected Everything looks fine. :cake:

djberg96 commented 6 years ago

All tests pass on my Windows 10 box.