search

ManageIQ / azure-armrest

Ruby interface for Azure using the new REST API
Apache License 2.0
15 stars 36 forks source link

Added some specs for list and list_all methods #346

Closed djberg96 closed 6 years ago

djberg96 commented 6 years ago

This is meant as a followup to https://github.com/ManageIQ/azure-armrest/pull/345.

This adds specs for the list and list_all methods for both StorageAccountService and VirtualMachineService. It includes specs for skipping the accessor definitions as well.

miq-bot commented 6 years ago

Checked commit https://github.com/djberg96/azure-armrest/commit/c5a71e0c29109fe3753a956e1df1adbb1bbc65a8 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 2 files checked, 0 offenses detected Everything looks fine. :trophy:

NickLaMuro commented 6 years ago

@djberg96 Thanks for doing this, this will be really helpful in the future I am sure.

Curious if you want to document somewhere the process of generating the json files you used as fixtures, in case we have to redo it in the future. I figured steps should include what was provisioned to get the data, what was replaced with dummy data (to prevent sensitive data from being stored in these files), etc.

djberg96 commented 6 years ago

@NickLaMuro I just used the Azure CLI and, in cases where there were too many results, I cherry picked a few out of the output. The only thing that really needs replacing for security reasons is the subscription ID, though I also renamed the resource group for testing purposes.

I can document this in the README I suppose.

NickLaMuro commented 6 years ago

@djberg96 fair enough. Though, if you don't want to clutter your main README.md, you probably could just toss a separate README.md into the spec/fixtures/ dir so it is gear specifically for creating new fixtures.