ManageIQ / azure-armrest

Ruby interface for Azure using the new REST API
Apache License 2.0
15 stars 36 forks source link

Fix custom inspect method spec #384

Closed djberg96 closed 5 years ago

djberg96 commented 5 years ago

We can't rely on attributes appearing in a specific order for our custom inspect method, so this PR modifies the spec so that it just checks for their presence.

miq-bot commented 5 years ago

Checked commit https://github.com/djberg96/azure-armrest/commit/aaec53c2f2ca34f25bab2035f4e687f11918e27e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 1 file checked, 0 offenses detected Everything looks fine. :trophy:

bzwei commented 5 years ago

@djberg96 please check the CI build

djberg96 commented 5 years ago

@bzwei Right, we need to remove 2.2.x from the matrix. Please ignore the 2.2.x failure since it's a bundler/travis issue.