ManageIQ / floe

Floe is a runner for Amazon States Language workflows
Apache License 2.0
0 stars 6 forks source link

Fix missing require active_support #114

Closed agrare closed 1 year ago

agrare commented 1 year ago

Active Support is pulled in from more_core_extensions. There is a require active_support/time in spec/workflow_spec that is now failing with 7.1

Fix for https://github.com/ManageIQ/floe/actions/runs/6420493122/job/17432692433

An error occurred while loading ./spec/workflow_spec.rb.
Failure/Error: require 'active_support/time'

NoMethodError:
  undefined method `deprecator' for ActiveSupport:Module
  Did you mean?  deprecate_constant
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/core_ext/array/conversions.rb:108:in `<class:Array>'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/core_ext/array/conversions.rb:8:in `<top (required)>'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/duration.rb:3:in `require'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/duration.rb:3:in `<top (required)>'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/core_ext/time/calculations.rb:3:in `require'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/core_ext/time/calculations.rb:3:in `<top (required)>'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/core_ext/time.rb:4:in `require'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/core_ext/time.rb:4:in `<top (required)>'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/time.rb:12:in `require'
# ./vendor/bundle/ruby/2.7.0/gems/activesupport-7.1.0/lib/active_support/time.rb:12:in `<top (required)>'
# ./spec/workflow_spec.rb:1:in `require'
# ./spec/workflow_spec.rb:1:in `<top (required)>'

with active_support 7.1.0

miq-bot commented 1 year ago

Checked commit https://github.com/agrare/floe/commit/ca390a6fc92332117d426efc4d224e4605223dbe with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :star:

agrare commented 1 year ago

Closing in favor of https://github.com/ManageIQ/floe/pull/116