Closed kbrock closed 1 year ago
No need for value_or_path The alternative is just as easy to read and even a hint shorter.
value_or_path
When I was writing this code, it was easier to reason through with this abstraction. Now, it is no longer necessary
@agrare you seemed to want to get away from this. Unfortunate that this adds some "complexity" to Wait#start
Wait#start
Checked commits https://github.com/kbrock/floe/compare/77ed8b0cf084f0478d092ff4c17a2732d347481d~...c1a026ac3ed377f4e353579a83ec38103f390260 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 3 files checked, 0 offenses detected Everything looks fine. :cake:
miq-bot
commented
1 year ago miq-bot
commented
1 year ago
No need for
value_or_pathThe alternative is just as easy to read and even a hint shorter.When I was writing this code, it was easier to reason through with this abstraction. Now, it is no longer necessary
@agrare you seemed to want to get away from this. Unfortunate that this adds some "complexity" to
Wait#start