search

ManageIQ / floe

Floe is a runner for Amazon States Language workflows
Apache License 2.0
0 stars 6 forks source link

Refactor the Podman runner to be a Docker subclass #140

Closed agrare closed 1 year ago

agrare commented 1 year ago

These two are so close that it seems like only a few overrides will allow us to remove a good amount of duplication

miq-bot commented 1 year ago

Checked commit https://github.com/agrare/floe/commit/98e72d9664a01bf6cf6c95c12b8936f46a9fdd01 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cookie:

kbrock commented 1 year ago

wow. I see run_continer on the chopping block next (after this merge)

agrare commented 1 year ago

I see run_continer on the chopping block next (after this merge)

100% just need to extract the params to a method then we can drop that one as well