extra cli options

[kbrock]

• Added logical shortcuts for parameters. (NOTE: docker runner changed from -d to -r)
• Added --docker, --podman, and --kubernetes shortcut

Before

Usage: floe [options] workflow input [workflow2 input2]

v0.7.0

Options:
  -w, --workflow=<s>                  Path to your workflow json (legacy)
  -i, --input=<s>                     JSON payload to input to the workflow (legacy)
  -c, --credentials=<s>               JSON payload with credentials
  -r, --credentials-file=<s>          Path to a file with credentials
  -d, --docker-runner=<s>             Type of runner for docker images (default: docker)
  -o, --docker-runner-options=<s+>    Options to pass to the runner
  -v, --version                       Print version and exit
  -h, --help                          Show this message

After

Usage: floe [options] workflow input [workflow2 input2]

v0.7.0

Options:
  -w, --workflow=<s>                  Path to your workflow json (legacy)
  -i, --input=<s>                     JSON payload to input to the workflow (legacy)
  -c, --credentials=<s>               JSON payload with credentials
  -e, --credentials-file=<s>          Path to a file with credentials
  -r, --docker-runner=<s>             Type of runner for docker images
  -o, --docker-runner-options=<s+>    Options to pass to the runner
  -d, --docker                        Use docker to run images     (short for --docker_runner=docker)
  -p, --podman                        Use podman to run images     (short for --docker_runner=podman)
  -k, --kubernetes                    Use kubernetes to run images (short for --docker_runner=kubernetes)
  -v, --version                       Print version and exit
  -h, --help                          Show this message

[kbrock]

update:

• added capitals
• added phrase shortcut
• added usage

[kbrock]

Todo:

• move input, creds to argv
• don't use input, credentials from args

Prep for multiple workflows

[kbrock]

update:

• removed argv changes (pulling into a separate PR)

[Fryguy]

Gah I commented in the wrong place - see https://github.com/ManageIQ/floe/pull/149#pullrequestreview-1770543621

[kbrock]

update:

• moved factory into a hash. used that hash for shortcuts, default, and factory
• changed shortcut verbiage from #149

ok, I used the TYPES value to drive the shortcuts. is this too cryptic?

[kbrock]

update:

• lost usage in rebases, added back
• updated git commit comment to reflect new --help output

[kbrock]

ugh. sorry, got confused, usage gets changed in the other pr. (that is why it was missing...)

update:

• removed usage string

[kbrock]

update:

• hardcoded values instead of being clever and using hash_table.each

[kbrock]

Updates:

• removed TYPES from runner.
• DEFAULT is a separate variable
• Optimist.die is moved and simplified

I like it how it is.

But there are a few possible changes:

• If we want to keep Runner::TYPES, then we can introduce set_runner(name="docker", options={}) and move the factory into there.
• If we want a default for docker-runner, then we will allow short flags to override longer flags.
• I keep wanting to change the code to have the options generated from TYPES, but find the code more confusing and not any shorter. So I keep tearing it back out.

[miq-bot]

Checked commit https://github.com/kbrock/floe/commit/e2557017ca6dd7d3bbb7c125fc9f919eb18370b1 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cake:

[kbrock]

update:

• extracted factory / constant definition into #152
• only introduce aliases.
• still changes the short form of credentials file, docker runner and docker runner options (to -e, -r and -o)

Outstanding

• I did like the docker_runner, :default => "docker", but we can't keep that and have long form override short form. So I dropped the default. Can have last one wins for short form (instead of first one wins)