ManageIQ / floe

Floe is a runner for Amazon States Language workflows
Apache License 2.0
0 stars 5 forks source link

Create docker runners factory and add scheme #152

Closed kbrock closed 7 months ago

kbrock commented 9 months ago

Defining the runners in a single place

Before

After

kbrock commented 9 months ago

update:

kbrock commented 9 months ago

Complexities that I can remove if you want:

  1. can remove supporting multiple schemas
  2. can remove supporting register with or without schema
kbrock commented 9 months ago

update:

update:

kbrock commented 8 months ago

update:

kbrock commented 8 months ago

update:

update:

kbrock commented 8 months ago

update:

kbrock commented 8 months ago

update:

update:

kbrock commented 7 months ago

update:

I had thought that pulling out the addition of a scheme would simplify things, but instead it has only added naming questions and confusion.

miq-bot commented 7 months ago

Checked commits https://github.com/kbrock/floe/compare/51d1917ac386bd3c2a364fb54a99901861cb7b87~...0d6b3a1f693b53607b7bf14e8625a04181683a36 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cookie: