search

ManageIQ / floe

Floe is a runner for Amazon States Language workflows
Apache License 2.0
0 stars 6 forks source link

step_nonblock_wait is no longer used #158

Closed kbrock closed 9 months ago

kbrock commented 9 months ago

If we need this method, then don't delete it. I just wanted to highlight that the code was not being called from here or provider-workflow

We are running wait/step_nonblocking_ready? on a list of workflows and no longer on a single workflow

After merging https://github.com/ManageIQ/floe/pull/157, I double checked that all the methods were being called...

Followup / or what this PR should be about:

I do feel that the main loop in exe/floe should be moved into Workflow. The version of wait isn't quite right and I like the version of exe/floe better.

agrare commented 9 months ago

I think this is still a useful method to have as part of the Floe::Workflow interface even if we don't use it in exe/floe right now. Plus eventually step_nonblock_wait could interrupt once the state is ready not just sleep

miq-bot commented 9 months ago

Checked commit https://github.com/kbrock/floe/commit/e2b2df29d7b5f5ffc48ef68883b50ff847eeb23d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cake: