Minor changes to increase Coverage - Githubissues

ManageIQ / floe

Floe is a runner for Amazon States Language workflows

Apache License 2.0

0 stars 5 forks source link

Minor changes to increase Coverage #185

Closed kbrock closed 3 months ago

kbrock commented 3 months ago

Timebox exercise to increase code coverage via SimpleCov

Mostly superficial test changes

one actual change to choice rule so it could show an invalid or missing compare_key

kbrock commented 3 months ago

update:

dropped the compare_key change

kbrock commented 3 months ago

update:

rebase

no other changes/no conflicts

kbrock commented 3 months ago

kicking (failure was due to run taking too long)

kbrock commented 3 months ago

update:

test floe log setters
Drop ReferencePath.get and set
test Context#success?
test workflow invalid state type
drop State#finished?
test workflow invalid payload

kbrock commented 3 months ago

update:

rebase
added State#finished back in with tests

update:

rubocop: removed trailing whitespace

miq-bot commented 3 months ago

Checked commits https://github.com/kbrock/floe/compare/8b559f0a6edb161720a640e93d8b47d8e216145b~...2f504f1727cd9f27c53c212ea1cea912464f79af with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 9 files checked, 0 offenses detected Everything looks fine. :trophy: