Extract ErrorMatcherMixin from Catch and Retry

ManageIQ / floe

Floe is a runner for Amazon States Language workflows

Apache License 2.0

0 stars 5 forks source link

Extract ErrorMatcherMixin from Catch and Retry #186

Closed kbrock closed 2 months ago

kbrock commented 3 months ago

Extract ErrorMatcherMixin#match_error?
States.HeartbeatTimeout is handled by States.Timeout
States.Runtime is not caught by any catchers/retriers

Fryguy commented 3 months ago

I think your branch name and PR title are wrong? (says "task catcher", but the PR guts are "error matcher"?)

kbrock commented 3 months ago

update:

fixed note
fixed specs (was not properly comparing equals_value)

kbrock commented 3 months ago

un-wip: tests passing

kbrock commented 3 months ago

update:

added error_equals validation

kbrock commented 3 months ago

update:

moved error_equals up to parent - no longer the Note stuff
added "States.ALL" special case
generalized Heartbeat special case
specs for ErrorMatcher

kbrock commented 3 months ago

update:

rewrote tests to go through workflow
added tests for validation
now checks that retrier (and catch) are non-empty

update:

ensure Retry/Catch are arrays
tests passing all rubies (removed tap from tests)

kbrock commented 3 months ago

update:

fix code complexity via validate_array_field!

kbrock commented 3 months ago

update:

compressed _catch_all case to convert guard into just a boolean ||

kbrock commented 3 months ago

update:

rebased
depend upon common error handling

kbrock commented 3 months ago

update:

rebase (fixed conflict)
rubocop: fixed spacing

kbrock commented 3 months ago

update:

renamed ErrorMatcher to ErrorMatcherMixin

kbrock commented 3 months ago

update:

based upon #209
Greatly simplified the logic in here.

kbrock commented 3 months ago

update:

remove 209 - trimmed it down

kbrock commented 3 months ago

update:

rubocop

kbrock commented 2 months ago

update:

extracted #212 (few pushes back) to make this as simple as I can

update:

rebase master

kbrock commented 2 months ago

@agrare @Fryguy this has been greatly simplified. Is this good to go now?

miq-bot commented 2 months ago

Checked commits https://github.com/kbrock/floe/compare/81fd2d0382e9d488ab76025c2f8c828c262faf01~...0928871a736728b82db8c124848e87ab7be0ea3f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 6 files checked, 0 offenses detected Everything looks fine. :cookie: