ManageIQ / floe

Floe is a runner for Amazon States Language workflows
Apache License 2.0
0 stars 5 forks source link

output now based upon raw input not effective input #191

Closed kbrock closed 3 months ago

kbrock commented 3 months ago

Context

// raw input
{
  "title": "Numbers to add",
  "numbers": { "val1": 3, "val2": 4 }
}

// result
7

// state
"InputPath": "$.numbers",
"ResultPath": "$.sum"

Before

// raw output:
{
  "val1": 3,
  "val2": 4,
  "sum": 7
}

After

// raw output:
{
  "title": "Numbers to add",
  "numbers": { "val1": 3, "val2": 4 },
  "sum": 7
}

refs:

Fryguy commented 3 months ago

Will this break any of our existing workflows like the ones in workflows-examples, or the new ootb ones?

kbrock commented 3 months ago

update:

miq-bot commented 3 months ago

Checked commits https://github.com/kbrock/floe/compare/53665201fe6812367818fda5394d8881942dfe63~...933eba165b6bbc33a5275553e2b748013ec7bb53 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 3 files checked, 0 offenses detected Everything looks fine. :+1:

kbrock commented 3 months ago

Searched through https://github.com/search?q=org%3AManageIQ%20path%3A*.asl&type=code (8 files)

and for agrare, fryguy

We don't use InputPath at all. so this should no affect us.

/cc @agrare - do you see any change that may be introduced if we are not using InputPath here?

That is probably why the bug has not been discovered yet

agrare commented 3 months ago

@kbrock yeah agreed I don't see any use of InputPath in our existing examples