ManageIQ / floe

Floe is a runner for Amazon States Language workflows
Apache License 2.0
0 stars 5 forks source link

[WIP] Move parameters into parent Mixins #212

Closed kbrock closed 2 months ago

kbrock commented 2 months ago

Style question:

Do we like the idea of moving the parameter reading into the mixin?

This shows what it looks like if we do this.

Depends upon:

Note: Pass does not support "ResultSelector". The old code was ignoring it. This is ignoring it as well. Since InputOutputMixin#process_output was already referencing result_selector, seemed ok to fully define that here.


WIP: Added WIP to mark this as a lower priority. it is ready

kbrock commented 2 months ago

update:

kbrock commented 2 months ago

WIP: this is a few commits in. not a conversation I want to have now But I do like this code and would like to merge when we are ready to talk about it

kbrock commented 2 months ago

update:

kbrock commented 2 months ago

update:

miq-bot commented 2 months ago

Checked commits https://github.com/kbrock/floe/compare/7a3b273bd9b1fe05601015018c3635c9266d87d5~...28fcaca20428d18276ecc553e082cd2cd660c84f with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 8 files checked, 0 offenses detected Everything looks fine. :trophy:

kbrock commented 2 months ago

This does extract some complexity from various states and consolidates all the relevant parameters together.

But it just feels like a refactor right now and doesn't move us forward