Common Error messages alt

[kbrock]

Alt to #209

This reads parameters, ensuring the data types, and no extra parameters. The errors explain the exact location of the incorrect attribute.

Unlike 209, this wraps the params with an object that knows the location and has type checking.

Details

• Fixes specs that don't define a Next.
• When state names are too long, display only the first 80 characters.
• All classes throws InvalidWorkflowError instead of relying upon later states to wrap unknown exceptions.
• Use PayloadValidator (instead of payload) to read values
• Detects unknown attributes.
• Enforces attribute types.
• All fields with validations. Separate PR for Choice, but now validates Paths
• Full context defined for Path or ReferencePath errors.

[kbrock]

update:

• cops

[kbrock]

update

• code climate simplification (only 7 -> 6)

update:

• fixed cops from previous code climate change
• code climate simplification 2

[kbrock]

update:

• introduce PayloadValidator#payload_template! to hopefully reduce code climate complexities and to make interface handle all examples

[kbrock]

update

• dropped fetch and key? to drop code complexity
• ensured all paths and templates are using helper methods
• still have 1 outstanding

update:

• rubocop

[miq-bot]

Checked commits https://github.com/kbrock/floe/compare/bf9efe655e62df768dbe613cc0a50c934350345c~...5592bd7e5a194e8155630cff8b3fc57e759a4ad7 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 23 files checked, 0 offenses detected Everything looks fine. :cookie:

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[kbrock]

merging this into #209

Decided to go with this code base