Closed kbrock closed 2 months ago
I would think any changes here should really live in manageiq-style, unless you think they are floe-specific?
@kbrock This morning in triage when looking at this we noticed that the manageiq-style .codeclimate.yml was never even installed. @agrare opened a PR for that in https://github.com/ManageIQ/floe/pull/224. I agree with tweaking the numbers, but think a) we should see if the manageiq-style .codeclimate.yml is sufficient and if not then I think it should be done over in manageiq-style if that makes sense globally.
Thanks. Yes, lets use the default.
@Fryguy so I'm not seeing any parameters that are code climate related.
Can we add another download section that holds/download codeclimate specific values?
I updated the codeclimate
to show what was not applied.
please advise where we want to add to styles and I can put a pr over there
@Fryguy so I'm not seeing any parameters that are code climate related.
The parameters come from the rubocop definitions instead, I believe. So, for example, cyclomatic complexity is 11 here: https://github.com/ManageIQ/manageiq-style/blob/master/styles/cc_base.yml#L38. I thought those values "overrode" the ones that are defaulted on code climate, but I could be wrong.
Can we add another download section that holds/download codeclimate specific values?
Absolutely, if the values from rubocop aren't working as expected.
Yes, I see that cyclomatic complexity has been introduced. Think it was not running at all before.
The file limits (code climate) are still being enforced (you can see that this PR resolves a number of code climate issues - suggesting that those values are just for the https://ruby.sadi.st/Heckle.html tools, and max code length are for other code tools.
good enough for now
Possible Values can be found: https://docs.codeclimate.com/docs/default-analysis-configuration
A few limits I feel are off. But this is here to start a conversation about what we want to modify.
method-lines
andfile-lines
-- These issues would trigger a complexity issue.method-count
-- It does show complexity, so this is up to you all.complexity-logic
from 5 to 10.For this repo, we have the following issues:
Workflow#initialize
complexity 17 > 5Workflow#wait
complexity 34 > 5,lines 45 > 25Docker#wait
complexity 29 > 5,lines 29 > 25Kubernetes
methods 24 > 20,lines 256 > 250Kubernetes#initialize
complexity 13 > 5Kubernetes#wait
complexity 21 > 5,lines 36 > 25Kubernetes#pod_spec
lines 40 > 25Kubernetes#cubeclient
complexity 9 > 5Context
methods 24 > 20Context#initialize
complexity 14 > 5Podman#global_docker_options
complexity 13 > 5Data#true?
lines 36 > 25ContainerRunner#resolve_cli_options!
complexity 7 > 5Task#initialize
complexity 7 > 5Task#parse_output
complexity 6 > 5State#wait
complexity 6 > 5Striked out entries would go away.