Move the guts of the CLI into a class for easier testing

ManageIQ / floe

Floe is a runner for Amazon States Language workflows

Apache License 2.0

0 stars 5 forks source link

Move the guts of the CLI into a class for easier testing #220

Closed Fryguy closed 2 months ago

Fryguy commented 2 months ago

Before: bundle exec rake  1.95s user 0.87s system 90% cpu 3.097 total
After:  bundle exec rake  0.67s user 0.25s system 94% cpu 0.981 total

I kept a singular test in there that ensures we are calling the exe/floe interface properly, but I'm really not sure if we need it or not. I'd be ok with dropping it. It would save an additional 0.13s knocking the time down to 0.85s or so

@kbrock Please review. Fixes #218

miq-bot commented 2 months ago

Some comments on commit https://github.com/Fryguy/floe/commit/49daace5292546ebf9f2064b5e3f7e2505df43a9

lib/floe/cli.rb

[ ] :warning: - 32 - Detected puts. Remove all debugging statements.
[ ] :warning: - 33 - Detected puts. Remove all debugging statements.

miq-bot commented 2 months ago

Checked commit https://github.com/Fryguy/floe/commit/49daace5292546ebf9f2064b5e3f7e2505df43a9 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 3 files checked, 0 offenses detected Everything looks fine. :cake: