Pass full path name to State.new for better errors

[kbrock]

Overview

statelint passes around the path to the states instead of just the name.

If we pass a full path to State and ChoiceRule we can improve validations

I want to go through each of the states to check all fields, but that just fixed up the existing errors and added a little bit of structure to help me fix ChoiceState

Changes:

- State requires ErrorEquals
+ States.State.Retry.0 does not have required field "ErrorEquals"
- State requires ErrorEquals
+ States.State.Retry.0 does not have required field "ErrorEquals"
- Choice state must have "Choices"
+ States.Choice1 does not have required field "Choices"
- "Choices" must be a non-empty array
+ States.Choice1 field "Choices" must be a non-empty array
- "Choices" must be a non-empty array
+ States.Choice1 field "Choices" must be a non-empty array
- "Default" not in "States"
+ States.Choice1 field "Default" value "MissingState" is not found in "States"
- Missing field "States"
+ State Machine does not have required field "States"
- Invalid state type: [Invalid]
+ States.FirstState field "Type" value "Invalid" is not valid
- Missing field "StartAt"
+ State Machine does not have required field "StartAt"
- "StartAt" not in the "States" field
+ State Machine field "StartAt" value "Foo" is not found in "States"
- Missing "Type" field in state [FirstState]
+ States.FirstState does not have required field "Type"
- State name [#{truncated_state_name}] must be less than or equal to 80 characters
+ States field "Name" value "#{state_name}" must be less than or equal to 80 characters
- Invalid resource scheme [invalid]
+ States.FirstState field "Resource" value "invalid://foo" Invalid resource scheme [invalid]

[kbrock]

update:

• using _full_name for Retrier. Won't use variable until we start validating those fields

[kbrock]

update:

• rubocop

[agrare]

I like this a lot, can you post an example error in the description of what it looked like before and after this change?

[kbrock]

@agrare This doesn't do much, it just passes around the name. Now that I know this is a viable direction, I have updated #209 to include the before and afters

[kbrock]

update:

• s/Retrier/Catcher -- a copy pasted error

[kbrock]

update:

• Added the validation messages changes from #209
• Cut down the common validation method to just a hand full of messages
• Did not add any new messages, but rather tried to minimize change

update:

• reduced flog score to make code climate happy

[kbrock]

update:

• updated an error! to a missing_field! (same output, just using the correct method) update:
• reduced flog of Workflow#initialize

[kbrock]

update:

• renamed full_name to name (added short_name for those that required just the current name)
• updated error names to reflect they are throwing an error
• dropped full_name_str (it was handled by a single join)
• wrap_parser_error added localized rescues for parsing paths and the like - will circle back for this.
• default Workflow name to "State Machine" (so we could drop full_name_str)
• move some workflow specs to the state they are testing
• Add tests around Next, End, missing Task#Resource

update:

• cops

update:

• rebase

[kbrock]

update:

• extracted workflow validations (fixing flog error)

update:

• passing workflow to everybody. (everyone but retrier needs it to validate Next. Simpler to make it consistent)

[miq-bot]

Checked commits https://github.com/kbrock/floe/compare/8ca4c222dd7918530bfb9f8c22c992897b54280a~...b485de6078b1f994af36d945c916f1962c9f3561 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 17 files checked, 0 offenses detected Everything looks fine. :star: