ManageIQ / floe

Floe is a runner for Amazon States Language workflows
Apache License 2.0
0 stars 5 forks source link

Fix sporadic test failure with Wait state #243

Closed agrare closed 1 month ago

agrare commented 2 months ago

I suspect there is an issue if the GHA runner is a little slow that the workflow.run_nonblock can finish before the expect(workflow.end?).to eq(false) can be invoked within 1 second.

https://github.com/ManageIQ/floe/actions/runs/9845986602/job/27182755884?pr=184

Failures:
  1) Floe::Workflow::States::Pass#running? with timestamp runs
     Failure/Error: expect(workflow.end?).to eq(false)

       expected: false
            got: true

Failed examples:

rspec ./spec/workflow/states/wait_spec.rb:94 # Floe::Workflow::States::Pass#running? with timestamp runs
miq-bot commented 1 month ago

Checked commit https://github.com/agrare/floe/commit/5fb6cee03dff396e3e101d8e8e48250a8af5a54c with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy: