Open kbrock opened 1 month ago
update:
update:
This feels like adding a lot of "code" to just present error messages. Is it possible to just not have the wrap_runtime_error
as that feels like the method that is adding a lot of this overhead?
I am curious why the PathError itself can't contain the details within, since it is being raised from within the Path itself. Additionally, is every instance of PathError just also an ExecutionError? If so, could it just raise an ExecutionError instead, or, if not, can PathError just be a subclass of ExecutionError?
@Fryguy The problem is a generically thrown exception will not properly have the context for the error. So either the thing throwing the error needs more information, or we need to add information on the way up.
I'll add the state/path to the Path
, so it can throw a better exception.
I'm not sure I follow... It looks like the same thing is passed into path that's wrapped outside of it as well
WIP: I care more about Choice fixes than error display. incorporating these errors on top of #189
update:
WIP: keeping up to date locally. waiting for choice to go through before putting too much effort into this. (they all conflict)
Also, my push more information into Path so it throws the fully qualified error instead of partial and having to manipulate the exception on the way up
Depends upon
2.5 things:
Invalid path (validation)
aws:
Before
After
Path not found (runtime)
aws:
Before
After