ManageIQ / integration_tests

ManageIQ integration tests
GNU General Public License v2.0
69 stars 165 forks source link

[RFR] Add module-scoped replicated_appliances fixture #10312

Closed tpapaioa closed 4 years ago

tpapaioa commented 4 years ago

Added module-scoped multi-region appliance fixture replicated_appliances_modscope, and replaced the function-scoped with this new module-scoped fixture in the tests in cfme/tests/distributed/test_appliance_replication.py. Because the tests previously didn't have to worry about cleanup, I've also added some finalizers to remove provider and other records after each test.

{{ pytest: --long-running --use-provider complete -k 'testreplication or test_appliancereplicate' cfme/tests/distributed/test_appliance_replication.py }}

dajoRH commented 4 years ago

I detected some fixture changes in commit e747dbcf49ee6e1d7f3d302ac15e40c2036a305d

The global fixture temp_appliance_preconfig_funcscope_rhevm was changed, but I didn't find where it's used. The global fixture temp_appliance_preconfig_modscope_rhevm was changed, but I didn't find where it's used. The global fixture temp_appliance_unconfig_modscope_rhevm was changed, but I didn't find where it's used. The global fixture replicated_appliances is used in the following files:

The global fixture replicated_appliances_modscope is used in the following files:

Please, consider creating a PRT run to make sure your fixture changes do not break existing usage :smiley: