[Scripting] QUICKSTART_DONE detection fails, interaction with shell and runtest

[mshriver]

QUICKSTART_DONE detection

The code in runtest does not detect when quickstart has already been completed, and re-runs quickstart every time miq-runtest is called: https://github.com/ManageIQ/integration_tests/blob/master/cfme/scripting/runtest.py#L8

This environment variable should be set by quickstart itself, not by miq-runtest. It should be checked by any other scripting modules that attempt to call quickstart.

Interaction with miq shell and miq-runtest

Quickstart is run every time miq shell is launched, regardless of if it has already been run: https://github.com/ManageIQ/integration_tests/blob/master/cfme/scripting/ipyshell.py#L19

The miq-runtest and miq shell commands, if running quickstart, should pass through the kwargs for the quickstart command.

If I'm using a non-standard configuration path, I cannot use miq shell as quickstart will fail

Passing these args through is in theory not necessary if the shell and runtest commands correctly detect that quickstart has completed already and don't try to run it again.

[RonnyPfannschmidt]

currently those are intentionally executing that way, "per design"

the main intend is to keep running quickstart on every invocation to ensure the environment

the question is what usage pattern you would like to see differently there

[mshriver]

In that case, the kwargs for quickstart need to be passed through. With the current design its impossible to run miq shell without using quickstart defaults (../cfme-qe-yamls/ config directory)

[RonnyPfannschmidt]

now- i based on context i believe we should strip down the quick-start invocations in those scripts to be more about ensuring python consistence (while assuming config consistence was taken care of

[RonnyPfannschmidt]

with my current role its unlikely i#l pick this one up