agrare
commented
2 years ago cc @jrafanie @kbrock for rails 6.1 upgrade
Closed agrare closed 2 years ago
agrare
commented
2 years ago cc @jrafanie @kbrock for rails 6.1 upgrade
miq-bot
commented
2 years ago lib/inventory_refresh/application_record_iterator.rb
yield.lib/inventory_refresh/inventory_collection.rb
lib/inventory_refresh/inventory_collection/builder.rb
%i-literals should be delimited by [ and ].lib/inventory_refresh/inventory_collection/helpers/initialize_helper.rb
%i-literals should be delimited by [ and ].lib/inventory_refresh/inventory_collection/helpers/questions_helper.rb
@parallel_safe_cache does not match method name parallel_safe?. Use @parallel_safe instead.%i-literals should be delimited by [ and ].lib/inventory_refresh/inventory_collection/index/proxy.rb
lib/inventory_refresh/inventory_collection/scanner.rb
if conditions.lib/inventory_refresh/inventory_object.rb
.exclude? and remove the negation part.lib/inventory_refresh/save_collection/saver/base.rb
if nested inside else to elsif.&.) instead of checking if an object exists before calling the method.&.) instead of checking if an object exists before calling the method.lib/inventory_refresh/save_collection/saver/concurrent_safe_batch.rb
lib/inventory_refresh/save_collection/saver/retention_helper.rb
%i-literals should be delimited by [ and ].lib/inventory_refresh/save_collection/saver/sql_helper.rb
<<-SQL.squish instead of <<-SQL.lib/inventory_refresh/save_collection/saver/sql_helper_update.rb
<<-SQL.squish instead of <<-SQL.lib/inventory_refresh/save_collection/saver/sql_helper_upsert.rb
<<-SQL.squish instead of <<-SQL.lib/inventory_refresh/save_collection/sweeper.rb
super to initialize state of the parent class.if conditions.lib/inventory_refresh/target_collection.rb
transform_values over each_with_object.spec/helpers/spec_parsed_data.rb
data.spec/helpers/test_builder/cloud_manager.rb
%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].spec/helpers/test_builder/shared.rb
%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].spec/helpers/test_persister.rb
super to initialize state of the parent class.spec/models/authentication.rb
ApplicationRecord.spec/models/manageiq/providers/cloud_manager.rb
=> should be surrounded by a single space.spec/models/manageiq/providers/cloud_manager/vm.rb
foreign_key is redundant.spec/models/vm_or_template.rb
spec/persister/local_db_finders_spec.rb
%w-literals should be delimited by [ and ].%w-literals should be delimited by [ and ].%w-literals should be delimited by [ and ].spec/persister/parallel_saving_spec.rb
%w-literals should be delimited by [ and ].spec/persister/persister_spec.rb
%i-literals should be delimited by [ and ].spec/persister/retention_strategies_spec.rb
vm2. Did you mean vm1?if-elsif to case-when.%i-literals should be delimited by [ and ].if-elsif to case-when.spec/save_inventory/acyclic_graph_of_inventory_collections_spec.rb
%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].spec/save_inventory/build_parent_inventory_collections_spec.rb
%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].spec/save_inventory/graph_of_inventory_collections_targeted_refresh_spec.rb
%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%w-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%w-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].miq-bot
commented
2 years ago spec/save_inventory/saver_strategies_spec.rb
spec/save_inventory/single_inventory_collection_spec.rb
%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].spec/save_inventory/strategies_and_references_spec.rb
%i-literals should be delimited by [ and ].%i-literals should be delimited by [ and ].spec/schema.rb
spec/target_collection_spec.rb
spec/target_spec.rb
Fryguy
commented
2 years ago @agrare Will this then be cut as a 1.0 release?
agrare
commented
2 years ago @Fryguy yes I figure once we get the rest of the rails 6.1 changes in I'd cut a v1.0.0
agrare
commented
2 years ago Think a rubocop -A might be in the cards as well :laughing:
agrare
commented
2 years ago Cross repo tests with all MIQ providers: https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/580
Fryguy
commented
2 years ago spec/schema.rb is like a huge chunk of those ...can probably ignore that file since it's autogenerated
agrare
commented
2 years ago Okay cross-repo is green
This adds back support for the save modes other than concurrent_safe batch (required by ManageIQ) and deletion other than mark&sweep (also required by ManageIQ).
Master (now v0.3.z) was always intended to maintain compatibility with ManageIQ but along the way it diverged too far in what was required by the application's database (unique constraints, foreign-key cascade delete triggers, etc...) to be able to be used by MIQ.
As MIQ moves closer to the reference architecture that topological-inventory set we can pull these back from the v0.3.z branch where possible.
This also allows us to add support for newer versions of active_record going forward, 6.0 support already was added to v0.2.z and we're looking at supporting 6.1 and 7.0 in the future