Closed agrare closed 2 years ago
are we thinking the failure for one and not the other means this is sporadic? Or are we thinking this broke something? (maybe a bug in rubocop)
Yeah I think rubocop actually broke some code, considering just dropping this or just having it fix the indentation and %[]
vs %()
issues
Yea. these should be no brainers, so anything that is a question mark should probably just remove the option that did those changes and proceed from there? I like Adam's suggestion of just doing the indentation and () -> []
.
lib/inventory_refresh/graph/topological_sort.rb
lib/inventory_refresh/inventory_collection.rb
lib/inventory_refresh/inventory_object.rb
spec/helpers/test_builder/container_manager.rb
spec/helpers/test_builder/shared.rb
spec/persister/retention_strategies_spec.rb
spec/save_inventory/single_inventory_collection_spec.rb
OK, ETOOMANY weird things...I figure you can eyeball these and do a first pass since we are seeing the same issues. Then after that I'll do a pass and see if there's anything else.