Run rubocop -A

[Fryguy]

OK, ETOOMANY weird things...I figure you can eyeball these and do a first pass since we are seeing the same issues. Then after that I'll do a pass and see if there's anything else.

[kbrock]

are we thinking the failure for one and not the other means this is sporadic? Or are we thinking this broke something? (maybe a bug in rubocop)

[agrare]

Yeah I think rubocop actually broke some code, considering just dropping this or just having it fix the indentation and %[] vs %() issues

[kbrock]

Yea. these should be no brainers, so anything that is a question mark should probably just remove the option that did those changes and proceed from there? I like Adam's suggestion of just doing the indentation and () -> [].

[miq-bot]

Checked commits https://github.com/agrare/inventory_refresh/compare/aec28c333461c2a9fdb76cff3171982ddb8e076a~...da35d3efcfd417d22ccc74f4bd9051b1679645aa with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 64 files checked, 24 offenses detected

lib/inventory_refresh/graph/topological_sort.rb

• [ ] :exclamation: - Line 23, Col 16 - Style/AsciiComments - Use only ascii symbols in comments.
• [ ] :exclamation: - Line 26, Col 18 - Style/AsciiComments - Use only ascii symbols in comments.
• [ ] :exclamation: - Line 30, Col 20 - Style/AsciiComments - Use only ascii symbols in comments.

lib/inventory_refresh/inventory_collection.rb

• [ ] :exclamation: - Line 95, Col 31 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 95, Col 54 - Naming/InclusiveLanguage - Consider replacing problematic term 'whitelist' with 'allowlist' or 'permit'.

lib/inventory_refresh/inventory_object.rb

• [ ] :exclamation: - Line 151, Col 17 - Performance/CollectionLiteralInLoop - Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.
• [ ] :exclamation: - Line 152, Col 17 - Performance/CollectionLiteralInLoop - Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.

spec/helpers/test_builder/container_manager.rb

• [ ] :exclamation: - Line 48, Col 19 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 75, Col 19 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.

spec/helpers/test_builder/shared.rb

• [ ] :exclamation: - Line 49, Col 23 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.

spec/persister/retention_strategies_spec.rb

• [ ] :exclamation: - Line 29, Col 9 - Performance/CollectionLiteralInLoop - Avoid immutable Array literals in loops. It is better to extract it into a local variable or a constant.

spec/save_inventory/single_inventory_collection_spec.rb

• [ ] :exclamation: - Line 285, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 301, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 304, Col 42 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 312, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'whitelist' with 'allowlist' or 'permit'.
• [ ] :exclamation: - Line 316, Col 42 - Naming/InclusiveLanguage - Consider replacing problematic term 'whitelist' with 'allowlist' or 'permit'.
• [ ] :exclamation: - Line 331, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 334, Col 42 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 343, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'whitelist' with 'allowlist' or 'permit'.
• [ ] :exclamation: - Line 346, Col 42 - Naming/InclusiveLanguage - Consider replacing problematic term 'whitelist' with 'allowlist' or 'permit'.
• [ ] :exclamation: - Line 399, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.
• [ ] :exclamation: - Line 438, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'whitelist' with 'allowlist' or 'permit'.
• [ ] :exclamation: - Line 478, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'whitelist' with 'allowlist' or 'permit'.
• [ ] :exclamation: - Line 479, Col 25 - Naming/InclusiveLanguage - Consider replacing problematic term 'blacklist' with 'denylist' or 'block'.