search

ManageIQ / inventory_refresh

Apache License 2.0
1 stars 23 forks source link

Allow Rails 6.1 #103

Closed agrare closed 2 years ago

agrare commented 2 years ago

are we testing these changes to the ancillary gemspecs or just merging them?

Just because this does deal with Active Record persistence so directly I'd like to run this through with cross-repo actually using rails 6.1, that way we can fix any issues in this PR

jrafanie commented 2 years ago

Just because this does deal with Active Record persistence so directly I'd like to run this through with cross-repo actually using rails 6.1, that way we can fix any issues in this PR

I'm currently trying this out with rails 6.1 locally with a manual cross repo run.

agrare commented 2 years ago

NOTE I've added rails 6.1 into the test matrix here

miq-bot commented 2 years ago

Checked commit https://github.com/agrare/inventory_refresh/commit/3a9b4109e5f223f157f2f1b60961ac51d20c3541 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie: