search

ManageIQ / inventory_refresh

Apache License 2.0
1 stars 23 forks source link

[WIP] Add an option to store record changes #115

Open agrare opened 1 year ago

agrare commented 1 year ago

Add the option to store changes to records that occurred during refresh.

TODO:

agrare commented 1 year ago

Pass a block to to_h instead of calling map.to_h.

NOTE this doesn't work on ruby 2.5 and was causing CI failures. Separately I'd like to drop 2.5 from the supported ruby versions but don't want to do that all in one PR

miq-bot commented 1 year ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot commented 1 year ago

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

kbrock commented 1 year ago

@agrare Thought this was almost ready (already ready?). Do we want to reopen?

agrare commented 1 year ago

I ran into issues with concurrent_safe batch and wasn't able to make progress

miq-bot commented 1 year ago

Checked commits https://github.com/agrare/inventory_refresh/compare/d454709389bcb7d389df3cc3e4925327534692ef~...87ab4097a039a3633f3d316462856373ef9a6460 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 8 files checked, 1 offense detected

lib/inventory_refresh/inventory_collection.rb

miq-bot commented 9 months ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot commented 6 months ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot commented 3 months ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).