search

ManageIQ / inventory_refresh

Apache License 2.0
1 stars 23 forks source link

Allow rails 7 gems in gemspec #119

Closed jrafanie closed 9 months ago

jrafanie commented 9 months ago

Allow rails 7 gems in gemspec

Note, I dropped ruby 2.5/rails 5.2 from the matrix since they are far EOL.

agrare commented 9 months ago

@jrafanie can you add rails 7.0 to the test matrix?

jrafanie commented 9 months ago

Sure, I'll manually push to this one. There's a handful of lib gems like this.

miq-bot commented 9 months ago

Checked commits https://github.com/jrafanie/inventory_refresh/compare/adef7e865ca2f4f793357abc96e17595325205ee~...be68fe71feb71cc44ed6b8ff0e87ccb0d5e2b59d with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :star:

jrafanie commented 9 months ago

@jrafanie can you add rails 7.0 to the test matrix?

hey, that was easy... I had to drop 2.5/5.2 and add ruby 3.1 which required me to safe_load aliases: true in two places. Since we're supporting old rubies here, I kept it with safe_load since safe_load_file was only added fairly recently and I don't know if it always supported passing aliases: true. I went with the ugly but more portable method.

agrare commented 8 months ago

Released v2.1.0 with this change