ManageIQ / inventory_refresh

Apache License 2.0
1 stars 23 forks source link

Fix the broken test matrix and drop old rubies and rails (breaking change) #139

Closed jrafanie closed 4 weeks ago

jrafanie commented 1 month ago

Fix the broken test matrix and drop old rubies and rails

The ci.yaml matrix of rubies and rails versions didn't match the case statement in the Gemfile. Rails 7.0 and 7.1 were not included in the case statement previously.

Now, we sync them up and make the following changes:

Drop:

Add:

We set a minimum ruby version of 3.0 and rails 7.0.8 and allow versions less than 8.0, so we can test with 7.1 and 7.2.

Rails 7.1 deprecated and 7.2 removed access to the deprecator instance

See: https://www.github.com/rails/rails/pull/47354

For now, we can maintain support for 7.0-7.2 by manually instantiating the object and not pass an explicit deprecator.

jrafanie commented 1 month ago

ooh, it's failing on rails 7.2 reasons... first one!

jrafanie commented 1 month ago

ooh, it's failing on rails 7.2 reasons... first one!

Looks like they removed the automatic access to the singleton instance of the deprecation class. Updated the code and description.

jrafanie commented 4 weeks ago

I think this is ready to go.