Closed agrare closed 6 years ago
lib/inventory_refresh/save_inventory/saver/base.rb
false
appeared as a condition.false
appeared as a condition.if
nested inside else
to elsif
.&.
) instead of checking if an object exists before calling the method.&.
) instead of checking if an object exists before calling the method.lib/inventory_refresh/save_inventory/saver/concurrent_safe.rb
update_all
because it skips validations.lib/inventory_refresh/save_inventory/saver/concurrent_safe_batch.rb
%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.lib/inventory_refresh/save_inventory/saver/sql_helper.rb
delegate
to define delegations.get_
.lib/inventory_refresh/save_inventory/saver/sql_helper_upsert.rb
%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.spec/save_inventory/acyclic_graph_of_inventory_collections_spec.rb
service
.spec/save_inventory/graph_of_inventory_collections_spec.rb
spec/save_inventory/graph_of_inventory_collections_targeted_refresh_spec.rb
%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%w
or %W
for an array of words.%i
or %I
for an array of symbols.%w
or %W
for an array of words.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.spec/save_inventory/saver_strategies_spec.rb
=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.=
should be surrounded by a single space.spec/save_inventory/single_inventory_collection_spec.rb
%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.%i
or %I
for an array of symbols.spec/save_inventory/strategies_and_references_spec.rb
%w
or %W
for an array of words.%i
or %I
for an array of symbols.%w
or %W
for an array of words.%w
or %W
for an array of words.hm @slemrmartin is rewriting the specs under /save_inventory, so this will conflict a lot, lets wait till that is done? :-)
PR @Ladas mentioned > https://github.com/ManageIQ/inventory_refresh/pull/19
Closing in favor of https://github.com/ManageIQ/inventory_refresh/pull/23
The recursive save_collection strategy isn't used and can be removed.
Also for simplicity this moves
InventoryRefresh::SaveCollection*
underInventoryRefresh::SaveInventory
since I found it confusing that save_inventory really didn't do anything and save_collection did all the work.