Remove Recursive save_collection strategy

[agrare]

The recursive save_collection strategy isn't used and can be removed.

Also for simplicity this moves InventoryRefresh::SaveCollection* under InventoryRefresh::SaveInventory since I found it confusing that save_inventory really didn't do anything and save_collection did all the work.

[miq-bot]

Checked commits https://github.com/agrare/inventory_refresh/compare/46f11993f607fbff7c80abdd857f8dd448c641e5~...a8eafa79338d1f5049d2abf5bda0bbfac7851c3a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 16 files checked, 211 offenses detected

lib/inventory_refresh/save_inventory/saver/base.rb

• [ ] :warning: - Line 251, Col 16 - Lint/LiteralAsCondition - Literal false appeared as a condition.
• [ ] :warning: - Line 277, Col 16 - Lint/LiteralAsCondition - Literal false appeared as a condition.
• [ ] :exclamation: - Line 162, Col 64 - Style/IfInsideElse - Convert if nested inside else to elsif.
• [ ] :exclamation: - Line 167, Col 11 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• [ ] :exclamation: - Line 17, Col 11 - Style/SafeNavigation - Use safe navigation (&.) instead of checking if an object exists before calling the method.
• [ ] :exclamation: - Line 185, Col 9 - Style/RescueStandardError - Avoid rescuing without specifying an error class.

lib/inventory_refresh/save_inventory/saver/concurrent_safe.rb

• [ ] :exclamation: - Line 28, Col 26 - Rails/SkipsModelValidations - Avoid using update_all because it skips validations.

lib/inventory_refresh/save_inventory/saver/concurrent_safe_batch.rb

• [ ] :exclamation: - Line 131, Col 9 - Style/RescueStandardError - Avoid rescuing without specifying an error class.
• [ ] :exclamation: - Line 178, Col 54 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 180, Col 54 - Style/SymbolArray - Use %i or %I for an array of symbols.

lib/inventory_refresh/save_inventory/saver/sql_helper.rb

• [ ] :exclamation: - Line 25, Col 9 - Rails/Delegate - Use delegate to define delegations.
• [ ] :exclamation: - Line 30, Col 13 - Naming/AccessorMethodName - Do not prefix reader method names with get_.

lib/inventory_refresh/save_inventory/saver/sql_helper_upsert.rb

• [ ] :exclamation: - Line 29, Col 44 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 87, Col 28 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 89, Col 26 - Style/SymbolArray - Use %i or %I for an array of symbols.

spec/save_inventory/acyclic_graph_of_inventory_collections_spec.rb

• [ ] :warning: - Line 462, Col 7 - Lint/UselessAssignment - Useless assignment to variable - service.
• [ ] :exclamation: - Line 593, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 594, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 612, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 615, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 632, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 633, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 666, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 667, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/save_inventory/graph_of_inventory_collections_spec.rb

• [ ] :exclamation: - Line 447, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 451, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 455, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 487, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 488, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 489, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 491, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 492, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 493, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 520, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 524, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 528, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 559, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 560, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 561, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 563, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 564, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 565, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 582, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 585, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 637, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 641, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 645, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 649, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 652, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 655, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 710, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 714, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 718, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 722, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 754, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 755, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 756, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 757, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 759, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 760, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 761, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 763, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 809, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 810, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 811, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 812, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 813, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 814, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 815, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 817, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 820, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 823, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 826, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 829, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 832, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 835, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 892, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 893, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 894, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 895, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 896, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 897, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 898, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 900, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 903, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 906, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 909, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 912, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 915, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 918, Col 7 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/save_inventory/graph_of_inventory_collections_targeted_refresh_spec.rb

• [ ] :exclamation: - Line 130, Col 38 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 132, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 133, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 135, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 159, Col 23 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 162, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 165, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 227, Col 23 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 229, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 232, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 299, Col 38 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 301, Col 15 - Style/WordArray - Use %w or %W for an array of words.
• [ ] :exclamation: - Line 321, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 325, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 330, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 333, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 392, Col 38 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 394, Col 15 - Style/WordArray - Use %w or %W for an array of words.
• [ ] :exclamation: - Line 408, Col 23 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 411, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 412, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 413, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 414, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 415, Col 7 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 418, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 422, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 426, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 430, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 47, Col 38 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 49, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 50, Col 17 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 52, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 56, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 59, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/save_inventory/saver_strategies_spec.rb

• [ ] :exclamation: - Line 104, Col 19 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 104, Col 21 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 147, Col 26 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 147, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 150, Col 20 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 150, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 153, Col 26 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 153, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 160, Col 48 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• [ ] :exclamation: - Line 166, Col 29 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 166, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 166, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 170, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 174, Col 29 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 174, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 174, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 178, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 179, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 182, Col 19 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 182, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 182, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 185, Col 20 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 185, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 185, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 188, Col 25 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 188, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 188, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 192, Col 25 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 192, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 192, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 196, Col 26 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 196, Col 31 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 196, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 201, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 202, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 59, Col 13 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 59, Col 15 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 62, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 63, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 64, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 70, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 71, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 72, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 75, Col 13 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 75, Col 15 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 78, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 79, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 80, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 83, Col 13 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 83, Col 15 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.
• [ ] :exclamation: - Line 90, Col 19 - Layout/ExtraSpacing - Unnecessary spacing detected.
• [ ] :exclamation: - Line 90, Col 21 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.

spec/save_inventory/single_inventory_collection_spec.rb

• [ ] :exclamation: - Line 296, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 313, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 316, Col 74 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 325, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 328, Col 74 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 340, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 343, Col 74 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 353, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 356, Col 74 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 408, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 449, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 490, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 491, Col 36 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 698, Col 3 - Style/SymbolArray - Use %i or %I for an array of symbols.

spec/save_inventory/strategies_and_references_spec.rb

[miq-bot]

...continued

• [ ] :exclamation: - Line 139, Col 33 - Style/WordArray - Use %w or %W for an array of words.
• [ ] :exclamation: - Line 14, Col 3 - Style/SymbolArray - Use %i or %I for an array of symbols.
• [ ] :exclamation: - Line 165, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 208, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 232, Col 36 - Style/WordArray - Use %w or %W for an array of words.
• [ ] :exclamation: - Line 233, Col 36 - Style/WordArray - Use %w or %W for an array of words.
• [ ] :exclamation: - Line 279, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 283, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 287, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 291, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 298, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 302, Col 9 - Naming/VariableNumber - Use normalcase for variable numbers.
• [ ] :exclamation: - Line 58, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 59, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 60, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 66, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 67, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 68, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 74, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 75, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.
• [ ] :exclamation: - Line 76, Col 13 - Layout/AlignHash - Align the elements of a hash literal if they span more than one line.

[Ladas]

hm @slemrmartin is rewriting the specs under /save_inventory, so this will conflict a lot, lets wait till that is done? :-)

[slemrmartin]

PR @Ladas mentioned > https://github.com/ManageIQ/inventory_refresh/pull/19

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[agrare]

Closing in favor of https://github.com/ManageIQ/inventory_refresh/pull/23