Do not store all deleted ids

ManageIQ / inventory_refresh

Apache License 2.0

1 stars 23 forks source link

Do not store all deleted ids #46

Closed Ladas closed 4 years ago

Ladas commented 5 years ago

We can have a lot of deleted records, which can cause massive memory spike. So we will count deleted records, but only store ids of a subset, with TODO that we should be streaming the ids as they come to a messaging service, not store them around.

miq-bot commented 5 years ago

Checked commit https://github.com/Ladas/inventory_refresh/commit/f69332ecf793533fc6d16fcb16c74c164d59c634 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 3 files checked, 0 offenses detected Everything looks fine. :trophy:

miq-bot commented 5 years ago

This pull request is not mergeable. Please rebase and repush.

miq-bot commented 4 years ago

This pull request has been automatically closed because it has not been updated for at least 6 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions!