Change FactoryGirl to FactoryBot

djberg96 commented 5 years ago

This PR is a followup to ManageIQ/manageiq#18279 where we're updating FactoryGirl to FactoryBot.

djberg96 commented 5 years ago

@miq-bot add_labels hammer/no, gaprindashvili/no, test

miq-bot commented 5 years ago

@djberg96 Cannot apply the following labels because they are not recognized: hammer/no, gaprindashvili/no

djberg96 commented 5 years ago

Not sure why 2.3.x failed. Is it a bundler issue?

djberg96 commented 5 years ago

To make Travis happy, I also updated the bundler version, since I think we'll be wanting the latest and greatest anyway.

Edit: oops, that just made it worse somehow.

Update: Aha, the .travis.yml file had the version specified. I've updated that.

miq-bot commented 5 years ago

Checked commit https://github.com/djberg96/inventory_refresh/commit/fafcd9536a3334e47daaf781aa171d1581673991 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 45 files checked, 33 offenses detected

spec/helpers/spec_mocked_data.rb

[ ] :exclamation: - Line 174, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 181, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 188, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 195, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 202, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 209, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 216, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/persister/finders_spec.rb

[ ] :exclamation: - Line 14, Col 31 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/persister/local_db_finders_spec.rb

[ ] :exclamation: - Line 16, Col 31 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/persister/retention_strategies_spec.rb

[ ] :warning: - Line 34, Col 11 - Lint/UselessAssignment - Useless assignment to variable - vm2.
[ ] :exclamation: - Line 16, Col 31 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/persister/serializing_spec.rb

[ ] :exclamation: - Line 14, Col 31 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/save_inventory/build_parent_inventory_collections_spec.rb

[ ] :exclamation: - Line 15, Col 31 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/save_inventory/graph_of_inventory_collections_spec.rb

[ ] :exclamation: - Line 1000, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 1008, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 1015, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 1021, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 1028, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 1034, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 1041, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 1048, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 958, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 965, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 972, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 979, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 986, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 993, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/save_inventory/saver_strategies_spec.rb

[ ] :exclamation: - Line 22, Col 35 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/save_inventory/strategies_and_references_spec.rb

[ ] :exclamation: - Line 18, Col 35 - Layout/AlignParameters - Align the parameters of a method call if they span more than one line.

spec/target_collection_spec.rb

[ ] :exclamation: - Line 14, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 7, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

spec/target_spec.rb

[ ] :exclamation: - Line 11, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.
[ ] :exclamation: - Line 5, Col 5 - Naming/VariableNumber - Use normalcase for variable numbers.

djberg96 commented 5 years ago

@miq-bot add_reviewer @agrare

djberg96 commented 5 years ago

@miq-bot add_reviewer @Fryguy

ManageIQ / inventory_refresh