Simplify the records iterator - Githubissues

ManageIQ / inventory_refresh

Apache License 2.0

1 stars 23 forks source link

Simplify the records iterator #76

Closed Ladas closed 5 years ago

Ladas commented 5 years ago

Simplify the iterator and allow it to run pure sql fetch (which will cause speedup). Make sure specs with this pass with serialized format too (there was a timestamp comparing change needed to pass all specs, since the pure SQL doesn't cast the timestamp for us)

miq-bot commented 5 years ago

Checked commits https://github.com/Ladas/inventory_refresh/compare/86bf2927796dd8193aff7fe12bdfbff929140bb7~...604cd07a0ddcbad3e79fa53de0fb1a952f3a8c4a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 8 files checked, 5 offenses detected

lib/inventory_refresh/inventory_collection.rb

[ ] :exclamation: - Line 494, Col 9 - Naming/AccessorMethodName - Do not prefix reader method names with get_.

spec/persister/parallel_saving_spec.rb

[ ] :exclamation: - Line 15, Col 6 - Layout/IndentHash - Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
[ ] :exclamation: - Line 17, Col 4 - Layout/IndentHash - Indent the right brace the same as the start of the line where the left brace is.

spec/persister/sweep_inactive_records_spec.rb

[ ] :exclamation: - Line 21, Col 22 - Layout/ExtraSpacing - Unnecessary spacing detected.
[ ] :exclamation: - Line 21, Col 29 - Layout/SpaceAroundOperators - Operator = should be surrounded by a single space.