Fixed attributes should contain all NOT NULL columns/relations

[Ladas]

Currently we were just adding columns with presence validation so we need to extend that to include NOT NULL constraints defined in the DB.

[Ladas]

@agrare I'd need this released for the Tower workflow structure (there is saving of cycle that was failing because of this)

[miq-bot]

Checked commit https://github.com/Ladas/inventory_refresh/commit/568c167dd862f9350470d19251d599dcfd88016a with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 2 files checked, 5 offenses detected

lib/inventory_refresh/inventory_collection.rb

• [ ] :exclamation: - Line 357, Col 57 - Layout/SpaceInsideBlockBraces - Space between { and | missing.
• [ ] :exclamation: - Line 357, Col 99 - Layout/SpaceInsideBlockBraces - Space missing inside }.

spec/save_inventory/single_inventory_collection_spec.rb

• [ ] :exclamation: - Line 329, Col 68 - Layout/MultilineArrayBraceLayout - The closing array brace must be on the same line as the last array element when the opening brace is on the same line as the first array element.
• [ ] :exclamation: - Line 340, Col 68 - Style/PercentLiteralDelimiters - %i-literals should be delimited by [ and ].
• [ ] :exclamation: - Line 362, Col 69 - Layout/MultilineArrayBraceLayout - The closing array brace must be on the same line as the last array element when the opening brace is on the same line as the first array element.

[lpichler]

@agrare can we create new release with this PR ?

When I was collecting new join table(service_instance_service_credential) between service_instances and service_offerings
I got this error: https://pastebin.com/p6yu2AVy

Issue is that source_id is missing in AS updated_values ( statement.

Using version 0.3.1 did not help but with this PR it is working.

thanks!

[agrare]

:+1: yes I'll release one now

[agrare]

Released https://rubygems.org/gems/inventory_refresh/versions/0.3.2

[lpichler]

🚀 🏎 thanks @agrare it was super fast 🏎 🚀