ManageIQ / inventory_refresh

Apache License 2.0
1 stars 23 forks source link

Parallel saving specs + renaming resource_version to resource counter #9

Closed Ladas closed 6 years ago

Ladas commented 6 years ago

Specs for ensuring cases for parallel saving using resource_counter and resource_timestamp columns + renaming resource_version to resource counter

miq-bot commented 6 years ago

Some comments on commits https://github.com/Ladas/inventory_refresh/compare/9f1f27733d2343ce68cc61f1bde84d247fc0f272~...e66808c5a1a0b9a6dd599ee9afa3761883cea497

spec/persister/parallel_saving_spec.rb

miq-bot commented 6 years ago

Checked commits https://github.com/Ladas/inventory_refresh/compare/9f1f27733d2343ce68cc61f1bde84d247fc0f272~...e66808c5a1a0b9a6dd599ee9afa3761883cea497 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 10 files checked, 5 offenses detected

lib/inventory_refresh/save_collection/saver/concurrent_safe_batch.rb

lib/inventory_refresh/save_collection/saver/sql_helper_upsert.rb

spec/schema.rb