Rails 6.0

[NickLaMuro]

Based off the v0.2.z branch, since master is v0.3.z+

Links

• Epic: https://github.com/ManageIQ/manageiq/issues/19977
• Current Cross Repo: https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/179

[agrare]

cc @slemrmartin

@NickLaMuro once this is passing specs I'm good with this if Martin is good from the topo side. As for MIQ we'll need to backport it to the v2 branch

[NickLaMuro]

@agrare I will look into the failures. That said...

As for MIQ we'll need to backport it to the v2 branch

This PR is already targeting the v0.2.z so it should actually be the reverse that needs to be done.

[agrare]

Gah sorry I missed that this was to the v2 branch I just assumed it was master my mistake

[NickLaMuro]

No worries, I did the same when I originally opened up the fix months ago, so it wasn't a wrong assumption to make, just one that I already have addressed (since it was causing major failures in cross-repo if I hadn't already solved for this).

[slemrmartin]

Hi @agrare yeah this PR won't affect us as it won't be merged to 0.3.z. We'll upgrade Rails probably in the Spring

[miq-bot]

Checked commits https://github.com/NickLaMuro/inventory_refresh/compare/628dfe84dd0ff254b94afe4571337a2d7f4f22f8~...5ce534d526d3b12207bf26e12c38f86186596c7a with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 10 files checked, 1 offense detected

**

• [ ] :bomb: :boom: :fire: :fire_engine: - Linter/Rubocop - Linter::Rubocop STDERR:

  
  404 "Not Found" while downloading remote config file https://raw.githubusercontent.com/ManageIQ/guides/master/.rubocop_base.yml
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/remote_config.rb:78:in `rescue in handle_response'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/remote_config.rb:73:in `handle_response'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/remote_config.rb:49:in `block in request'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/remote_config.rb:63:in `generate_request'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/remote_config.rb:47:in `request'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/remote_config.rb:21:in `file'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_loader.rb:40:in `load_file'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_loader_resolver.rb:143:in `block in base_configs'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_loader_resolver.rb:142:in `map'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_loader_resolver.rb:142:in `base_configs'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_loader_resolver.rb:22:in `resolve_inheritance'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_loader.rb:50:in `load_file'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_loader.rb:89:in `configuration_from_file'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/config_store.rb:44:in `for'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/target_finder.rb:107:in `excluded_dirs'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/target_finder.rb:85:in `find_files'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/target_finder.rb:60:in `target_files_in_dir'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/target_finder.rb:31:in `find'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/runner.rb:64:in `find_target_files'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/runner.rb:34:in `run'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/cli/command/execute_runner.rb:21:in `execute_runner'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/cli/command/execute_runner.rb:13:in `run'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/cli/command.rb:10:in `run'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/cli/environment.rb:17:in `run'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/cli.rb:65:in `run_command'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/cli.rb:72:in `execute_runners'
  /usr/share/gems/gems/rubocop-0.82.0/lib/rubocop/cli.rb:41:in `run'
  /usr/share/gems/gems/rubocop-0.82.0/exe/rubocop:13:in `block in <top (required)>'
  /usr/share/ruby/benchmark.rb:308:in `realtime'
  /usr/share/gems/gems/rubocop-0.82.0/exe/rubocop:12:in `<top (required)>'
  /usr/bin/rubocop:23:in `load'
  /usr/bin/rubocop:23:in `<main>'

[agrare]

Released v0.2.3 with this change

[agrare]

I should mention I'm very excited about the ability to use this with rails 6 because of the introduction of #upsert which might be able to replace our raw SQL ON CONFLICT UPDATE logic for concurrent safe batch saving.

[NickLaMuro]

@agrare Nice! The cross-repo PR for Rails 6.0 is now running with all of these newly released gems:

https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/179

I think those were the last hold out for merging them into master... 🤞