search

ManageIQ / inventory_refresh

Apache License 2.0
1 stars 23 forks source link

Switch to manage-style #96

Closed bdunne closed 3 years ago

bdunne commented 3 years ago

Inspired by https://github.com/ManageIQ/inventory_refresh/pull/95#issuecomment-745390321

NickLaMuro commented 3 years ago

@bdunne lol, I just started this because of the failures in my PR 😆

miq-bot commented 3 years ago

Checked commit https://github.com/bdunne/inventory_refresh/commit/f53317341ad0c94b32c417bb3b71dbd6405d8a9a with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :trophy:

bdunne commented 3 years ago

Ok, I re-ran with the latest manageiq-style. I think this addresses all of the codeclimate issues, but since they pull the config from master, we need to merge before we know for sure. If all goes well here, I'll blast out the changes to the other repos.

I know @Fryguy is taking some time off, @agrare or @jrafanie can you take a look?

bdunne commented 3 years ago

Looks like it worked. I'll blast out PRs to the other repos next week.

Fryguy commented 2 years ago

Backported to v0.2.z because the old .rubocop_base.yml via guides is no longer cached on github. cc @agrare