search

ManageIQ / kubeclient

A Ruby client for Kubernetes REST API
MIT License
419 stars 167 forks source link

Backport changes to the AWS EKS Credentials into the v4.y branch for release #634

Closed snorlaX-sleeps closed 5 months ago

snorlaX-sleeps commented 5 months ago

This PR adds regional support to the method, as well as allowing the kuebclient gem to be used in govcloud All of this code is available from the main branch and was added in the following PRs:

Without these (old) changes, the currently released gem is unusable. Some of these changes were added before the v5 cutoff started, but never got released

Fixes: #527

Changes tested in our account - currently patching a copy of this file into our Docker build, overwriting the latest release

snorlaX-sleeps commented 5 months ago

@miq-bot add-label enhancement @miq-bot add-label aws @miq-bot add-label eks @miq-bot add-label aws_eks

agrare commented 5 months ago

Thanks for the nudge @snorlaX-sleeps, I'll backport these commits and get the v4.y branch green on CI and release a v4.12.0 shortly

snorlaX-sleeps commented 5 months ago

Thanks @agrare - I was unsure of the process around backporting, but this was a blocker for the last week or two and it's only when I really went digging that I remembered this was a thing a few years back 🙂

agrare commented 5 months ago

@snorlaX-sleeps I've released v4.12.0 including the three PRs that you linked here https://github.com/ManageIQ/kubeclient/releases/tag/v4.12.0 https://rubygems.org/gems/kubeclient/versions/4.12.0

Let me know if that works for you, thanks!

agrare commented 5 months ago

I was unsure of the process around backporting

Yeah I like to cherry-pick individual merge commits to maintain the commit history and include a changelog and summary in gpg-signed commit and tag.

agrare commented 5 months ago

There is a failure on windows x truffleruby-head and that test doesn't exist on master which is interesting it went straight to v4.y but it is a setup failure not a code failure, might revert that PR that added the test only to v4.y and backport it properly once the master PR is merged.

snorlaX-sleeps commented 5 months ago

thanks @agrare - I've done a local test with the new gem, with the expected result, will attempt a full build and test tomorrow!

snorlaX-sleeps commented 5 months ago

@agrare - can confirm this is now working for us in both commercial and govcloud AWS accounts. Going to close this since you've already backported the change 🙂 Thanks for jumping on this so quickly

agrare commented 5 months ago

Awesome glad to hear it @snorlaX-sleeps