ManageIQ / manageiq-api-client

Ruby client library to the ManageIQ REST API
MIT License
11 stars 26 forks source link

Drop More core extensions and active_support dependencies #115

Closed kbrock closed 6 months ago

kbrock commented 6 months ago

https://github.com/ManageIQ/query_relation/pull/31 removes these same dependencies from query_relation

Before

# Gemfile

gem "manageiq-api-client"
bundle update
=> 26 gems

After

bundle update
=> 12 gems
kbrock commented 6 months ago

great find

update:

Fryguy commented 6 months ago

There's also a reference to the rails version here that needs to be removed (I'm actually surprised the workflow ran at all)

https://github.com/ManageIQ/manageiq-api-client/blob/d91929a7a2cc2b3b6a4ff757ae1232a3638b2ef9/.github/workflows/ci.yaml#L36

kbrock commented 6 months ago

thanks.

update:

Frustrating: I had made that change but for some reason, it didn't get into the commit