search

ManageIQ / manageiq-api-client

Ruby client library to the ManageIQ REST API
MIT License
11 stars 26 forks source link

[WIP] updating faraday and middleware versions #89

Closed d-m-u closed 4 years ago

d-m-u commented 4 years ago

oh I don't know @bdunne could you please review? or anyone?

agrare commented 4 years ago

@d-m-u specs are failing

d-m-u commented 4 years ago

@agrare, fine, want to take another look?

abellotti commented 4 years ago

strange that we're pulling in an RC version for the middleware, is that the intent ? (i.e. 0.14.0 wouldn't help us here)

agrare commented 4 years ago

API client isn't my thing :) I'll let @bdunne and @abellotti take a look

d-m-u commented 4 years ago

@abellotti want me to wait for one that isn't rc? 0.14.0 will not work for this, no. its faraday is capped at < 1.0.0 and we need at minimum the 1.0 release.

abellotti commented 4 years ago

Can we wait ? that'd be preferred, i.e. having all the kinks out before we pull it into production here. /cc @bdunne thoughts ?

abellotti commented 4 years ago

btw, I have the latest local gems installed and client seems to work fine with 0.14.0 of the middleware.

faraday (1.0.0, 0.17.3, 0.17.0, 0.9.2) faraday_middleware (0.14.0, 0.13.1, 0.10.1)

ManageIQ::API::Client.new.vms.where(:name => "aab*").collect(&:name)

what was it that 1.0.0.rc1 fixes for us ?

d-m-u commented 4 years ago

We're been putting off updating Faraday for years, and it's time to update to 1.0.0.

abellotti commented 4 years ago

you're right.

image

while it runs fine with it locally, the faraday_middleware gem dependency fails.

abellotti commented 4 years ago

looks like it's very close to becoming official, https://github.com/lostisland/faraday_middleware/issues/200 folks are kicking the tire. I'd wait before we pull it in to production.

bdunne commented 4 years ago

Is there a source of urgency behind this PR? Like a security issue or something?

d-m-u commented 4 years ago

No, it's fine. It's marked as WIP. I'm just impatient.

iMacTia commented 4 years ago

@d-m-u FaradayMiddleware 1.0 has now been released: https://rubygems.org/gems/faraday_middleware/versions/1.0.0