ManageIQ / manageiq-api

ManageIQ API
Apache License 2.0
20 stars 143 forks source link

Add picture id to service catalog #1262

Open GilbertCherrie opened 3 months ago

GilbertCherrie commented 3 months ago

In Manage-IQ ui-service there is an issue where the logo of an order is not using the custom logo that users upload for catalog items.

UI-Service Logo:

Screenshot 2024-06-21 at 10 03 29 AM

Custom Logo set in UI-Classic

Screenshot 2024-06-21 at 10 04 06 AM

In order to use the custom logo in the service ui we need the api to return the image id associated with this service template / service order. The summary page in the UI-service is calling /api/service_orders/id, ideally this api call returns the image id associated with the order / template so that we can render the appropriate image in the service ui.

Fryguy commented 3 months ago

As we discussed in PM, the service catalog items have the picture id, so you can get it indirectly by fetching the service catalog item. That being said, I could see it being useful if the service itself and/or the order itself had the value directly, particularly if the user doesn't have RBAC permissions to the catalog entries.

Fryguy commented 3 months ago

Not sure if we should de-normalize it, or make it a virtual_attribute. I was originally thinking denormalize it (in case the catalog item goes away), but then I think it could get orphaned.

miq-bot commented 1 day ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.