ManageIQ / manageiq-appliance-build

Scripts to build ManageIQ appliances
Apache License 2.0
10 stars 55 forks source link

Add build type (release or nightly) support to container build #435

Closed simaishi closed 4 years ago

simaishi commented 4 years ago

Also changed to use getopts and removed environment variables (MIQ_REF, SUI_REF and APPLIANCE_REF) that are no longer used.

Requires https://github.com/ManageIQ/manageiq-pods/pull/597

Fryguy commented 4 years ago

One minor comment...rest looks good to me.

miq-bot commented 4 years ago

Checked commits https://github.com/simaishi/manageiq-appliance-build/compare/6c70ecdc2e2f1dc28917708bdc237e4a34762378~...4d223b65bdafd55bfe1afb16810b784bfa6fa83e with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cake:

simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit ea704ca11612208cffc3b7fc7b40ff59b31a05d1
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Aug 26 11:17:45 2020 -0400

    Merge pull request #435 from simaishi/pods_release_build

    Add build type (release or nightly) support to container build

    (cherry picked from commit 35925789723be3ea968bf409c766ef7f50ddeb55)