search

ManageIQ / manageiq-appliance-build

Scripts to build ManageIQ appliances
Apache License 2.0
10 stars 55 forks source link

Align repo names with the official names #439

Closed Fryguy closed 4 years ago

Fryguy commented 4 years ago

Follow up to https://github.com/ManageIQ/manageiq-appliance/pull/293

@simaishi Please review.

Fryguy commented 4 years ago

Only one I'm not sure about is google-cloud-compute...do you know what's in the .repo file for that one?

simaishi commented 4 years ago

Only one I'm not sure about is google-cloud-compute...do you know what's in the .repo file for that one?

We specify the repo name for post installation (as we have to manually create the repo file): https://github.com/ManageIQ/manageiq-appliance-build/blob/master/kickstarts/partials/post/repos.ks.erb

simaishi commented 4 years ago

Looks good, just need change for gce (google-compute-engine vs google-cloud-compute)

miq-bot commented 4 years ago

Checked commit https://github.com/Fryguy/manageiq-appliance-build/commit/dd1680fd5666a849d89e2c91ca68dbd7af71a8f4 with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :+1:

Fryguy commented 4 years ago

@simaishi Updated.

simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit 36770d83dd0db8eb1eb4fb44f863848851449c95
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Wed Sep 16 11:12:24 2020 -0400

    Merge pull request #439 from Fryguy/align_names

    Align repo names with the official names

    (cherry picked from commit bec064ece6146a9877bfb91c609609a741836419)