ManageIQ / manageiq-appliance-build

Scripts to build ManageIQ appliances
Apache License 2.0
10 stars 55 forks source link

Allow for productization of build #446

Closed Fryguy closed 4 years ago

Fryguy commented 4 years ago

@simaishi Please review

This PR adds

cc @bennett-white

Fryguy commented 4 years ago

@simaishi I am ignoring these rubocops because they are existing code or not relevant.

simaishi commented 4 years ago

Please add product_name to bin/kickstart_build.rb as well.

Fryguy commented 4 years ago

@simaishi Updated.

miq-bot commented 4 years ago

Checked commit https://github.com/Fryguy/manageiq-appliance-build/commit/6af379f4d6cb3efda63af64477eea6c2465894ed with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 8 files checked, 12 offenses detected

scripts/cli.rb

scripts/spec/cli_spec.rb

scripts/spec/productization_spec.rb

simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit df22f422a088062331caa36e0653a6353ddc343c
Author: Satoe Imaishi <simaishi@redhat.com>
Date:   Tue Oct 20 10:10:25 2020 -0400

    Merge pull request #446 from Fryguy/productize_build

    Allow for productization of build

    (cherry picked from commit 633eb44b90d05e04588af4f7387b513cba6199b8)