Typo env should be ENV - Githubissues

bdunne commented 1 year ago

Followup to #545

miq-bot commented 1 year ago

Checked commit https://github.com/bdunne/manageiq-appliance-build/commit/a42dd001a3577bdfc1932021e10db4a3659576e1 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 3 offenses detected

scripts/uploader.rb

[ ] :exclamation: - Line 68, Col 25 - Style/FetchEnvVar - Use ENV.fetch("IBM_CLOUD_ACCESS_KEY") or ENV.fetch("IBM_CLOUD_ACCESS_KEY", nil) instead of ENV["IBM_CLOUD_ACCESS_KEY"].
[ ] :exclamation: - Line 69, Col 25 - Style/FetchEnvVar - Use ENV.fetch("IBM_CLOUD_SECRET_KEY") or ENV.fetch("IBM_CLOUD_SECRET_KEY", nil) instead of ENV["IBM_CLOUD_SECRET_KEY"].
[ ] :exclamation: - Line 70, Col 25 - Style/FetchEnvVar - Use ENV.fetch("IBM_CLOUD_ENDPOINT") or ENV.fetch("IBM_CLOUD_ENDPOINT", nil) instead of ENV["IBM_CLOUD_ENDPOINT"].

Fryguy commented 1 year ago

Backported to petrosian in commit ea80cc54acb364432208d9f6ed7a17339cb6e126.

commit ea80cc54acb364432208d9f6ed7a17339cb6e126
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed May 3 14:12:03 2023 -0400

    Merge pull request #546 from bdunne/ibm_cloud

    Typo env should be ENV

    (cherry picked from commit 44e70aa6719f8e9c0d1022ded6dd0432383a78ab)

ManageIQ / manageiq-appliance-build

Typo env should be ENV #546