add secure headers to apache

ManageIQ / manageiq-appliance

System files for the ManageIQ appliance.

Apache License 2.0

7 stars 50 forks source link

add secure headers to apache #358

Closed kbrock closed 2 years ago

kbrock commented 2 years ago

Adding cross site secure headers for static resources to the appliance

This is the appliance version of https://github.com/ManageIQ/manageiq-pods/pull/823

Fryguy commented 2 years ago

Have some comments over in the pods PR...let's work it out there.

miq-bot commented 2 years ago

Checked commit https://github.com/kbrock/manageiq-appliance/commit/662e803625a5bfcb5aafd68400e898bcfe05ff7d with ruby 2.6.7, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :star:

kbrock commented 2 years ago

update:

set self for all attributes
removed unnecessary , after attributes (read: fixed syntax error)

I tested this with a container apache and rails s I did get the javascript working but the stylesheets were not set correctly (since I couldn't find any)

Fryguy commented 2 years ago

Backported to najdorf in commit 4d2550ab746511ab13a90c1da5ccf1c75d284f76.

commit 4d2550ab746511ab13a90c1da5ccf1c75d284f76
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri May 20 09:23:44 2022 -0400

    Merge pull request #358 from kbrock/session_same_site

    add secure headers to apache

    (cherry picked from commit 514e633b83c8f702a8519f935f42c3a741fd47ba)

Fryguy commented 2 years ago

Backported to morphy in commit 0a638ec0bacfe3610b85ea75f09275ffe12b6bc0.

commit 0a638ec0bacfe3610b85ea75f09275ffe12b6bc0
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri May 20 09:23:44 2022 -0400

    Merge pull request #358 from kbrock/session_same_site

    add secure headers to apache

    (cherry picked from commit 514e633b83c8f702a8519f935f42c3a741fd47ba)