Reload database.yml in loop to pick up changes

ManageIQ / manageiq-appliance

System files for the ManageIQ appliance.

Apache License 2.0

7 stars 50 forks source link

Reload database.yml in loop to pick up changes #364

Closed agrare closed 2 years ago

agrare commented 2 years ago

If the database.yml file is modified after the manageiq-db-ready unit starts the changes were not being picked up and manageiq-db-ready would hang.

Fixes https://github.com/ManageIQ/manageiq-appliance_console/issues/188

miq-bot commented 2 years ago

Checked commit https://github.com/agrare/manageiq-appliance/commit/ebd826712765947959059a01e68c4d5b4fe02d41 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :trophy:

miq-bot commented 2 years ago

Some comments on commit https://github.com/agrare/manageiq-appliance/commit/ebd826712765947959059a01e68c4d5b4fe02d41

COPY/usr/bin/manageiq-db-ready

[ ] :warning: - 17 - Detected puts. Remove all debugging statements.
[ ] :warning: - 20 - Detected puts. Remove all debugging statements.
[ ] :warning: - 31 - Detected puts. Remove all debugging statements.

Fryguy commented 2 years ago

Backported to najdorf in commit 181aeafe7196c0a67300de1eb44420e86dbd96c1.

commit 181aeafe7196c0a67300de1eb44420e86dbd96c1
Author: Jason Frey <fryguy9@gmail.com>
Date:   Mon Aug 15 17:46:32 2022 -0400

    Merge pull request #364 from agrare/reload_database_yml

    Reload database.yml in loop to pick up changes

    (cherry picked from commit 122f2605931e5c74590c5b92ae732a425cc04ab1)