Move TERRAFORM_RUNNER_URL to appliance specific properties

ManageIQ / manageiq-appliance

System files for the ManageIQ appliance.

Apache License 2.0

7 stars 50 forks source link

Move TERRAFORM_RUNNER_URL to appliance specific properties #386

Closed agrare closed 5 months ago

agrare commented 5 months ago

Follow-up to https://github.com/ManageIQ/manageiq-appliance/pull/385

I didn't realize that /etc/default/manageiq.properties was also present on podified (since it was in manageiq-appliance repo :laughing:)

This adds an appliance-specific properties file which we can package only in the appliance rpm

Follow-up:

RPM build changes to only install this file on appliances https://github.com/ManageIQ/manageiq-rpm_build/pull/464

miq-bot commented 5 months ago

Checked commit https://github.com/agrare/manageiq-appliance/commit/bfa59ccb54861bb1bdf98307753f9ead3ea2c02a with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :trophy:

Fryguy commented 5 months ago

Backported to radjabov in commit a0ec19595b0cb077a516847d406400664caf9c49.

commit a0ec19595b0cb077a516847d406400664caf9c49
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed May 29 11:24:36 2024 -0400

    Merge pull request #386 from agrare/add_manageiq_appliance_specific_properties

    Move TERRAFORM_RUNNER_URL to appliance specific properties

    (cherry picked from commit bdf299cdb579e193bb56a8e4dc1859425334f677)