search

ManageIQ / manageiq-appliance_console

The console for the ManageIQ appliances.
Apache License 2.0
2 stars 28 forks source link

Messaging keystore password validation #255

Closed nasark closed 3 months ago

nasark commented 3 months ago

During appliance install, when using a messaging keystore password with special characters the appliance setup will fail. This appears to be a JKS (Java Keystore) limitation and should be addressed by preventing entry of passwords with special characters

@miq-bot assign @agrare @miq-bot add_label bug @miq-bot add_reviewer @agrare

agrare commented 3 months ago

@nasark does JKS not support any special characters or only some? I've used passwords before with some special characters and they appear to have worked, I know in this specific case it was # that failed

nasark commented 3 months ago

@nasark does JKS not support any special characters or only some? I've used passwords before with some special characters and they appear to have worked, I know in this specific case it was # that failed

@agrare The only special characters that worked in my testing are $, *, which I can add to the regex to allow them... it's possible that the allowed special characters differ between Java versions

agrare commented 3 months ago

Nope those just happened to be the two special chars that I used so I thought maybe it was only # that failed :)

Yeah could you add those to the regex and update the error message to indicate what is allowed

miq-bot commented 3 months ago

Checked commit https://github.com/nasark/manageiq-appliance_console/commit/65ac35c4e1c192f41ed8c33fd100263a260adb43 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 4 files checked, 0 offenses detected Everything looks fine. :star: