Deprecate message-server-use-ipaddr option from CLI

ManageIQ / manageiq-appliance_console

The console for the ManageIQ appliances.

Apache License 2.0

2 stars 28 forks source link

Deprecate message-server-use-ipaddr option from CLI #257

Closed nasark closed 3 months ago

nasark commented 3 months ago

We no longer allow IPs to be used for messaging hosts and so the message-server-use-ipaddr option in the CLI should be deprecated

@miq-bot assign @agrare @miq-bot add_label bug @miq-bot add_reviewer @agrare

agrare commented 3 months ago

@nasark could you add a warning if someone passes the ip address flag? Something like $stderr.puts "--message_server_use_ipaddr is deprecated and will be ignored" if options[:message_server_use_ipaddr]

miq-bot commented 3 months ago

Some comments on commit https://github.com/nasark/manageiq-appliance_console/commit/b6fbe3c71288fb2754e641e6bc0e309d41132734

lib/manageiq/appliance_console/cli.rb

[ ] :warning: - 227 - Detected puts. Remove all debugging statements.

miq-bot commented 3 months ago

Checked commit https://github.com/nasark/manageiq-appliance_console/commit/b6fbe3c71288fb2754e641e6bc0e309d41132734 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 4 files checked, 1 offense detected

lib/manageiq/appliance_console/cli.rb

[ ] :exclamation: - Line 227, Col 7 - Style/StderrPuts - Use warn instead of $stderr.puts to allow such output to be disabled.