ManageIQ / manageiq-appliance_console

The console for the ManageIQ appliances.
Apache License 2.0
2 stars 28 forks source link

Make the appliance console file a class that we can run #8

Open miq-bot opened 7 years ago

miq-bot commented 7 years ago

Right now the console is a big script which is run when it is required.

We would rather make it a class or module that has a .run method which can take parameters instead of relying on environment variables such as RAILS_ROOT.


This issue was moved to this repository from https://github.com/ManageIQ/manageiq-gems-pending/issues/12, originally opened by @carbonin

miq-bot commented 6 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

kbrock commented 6 years ago

I think this is good in theory, and has been a concern for over 4 years.

Extracting the actual work into separate command pattern objects seemed to be the least amount of work.

This has the benefit of being smaller steps, easier to test, and being used from the appliance console cli.

I admit, I had dreams of adding a web interface to these commands many moons ago, but think I am over it now.

JPrause commented 5 years ago

@carbonin is this still a valid issue? If yes, please remove the stale label. If not can you close. If there's no update by next week, I'll be closing this issue.

carbonin commented 5 years ago

Yeah, I think this is still a valid RFE.

JPrause commented 5 years ago

Thanks @carbonin